Skip to content

[PM-32384] Update copy new to create/add browser#21524

Open
jengstrom-bw wants to merge 42 commits into
mainfrom
vault/pm-32384/update-copy-new-to-create-add-browser
Open

[PM-32384] Update copy new to create/add browser#21524
jengstrom-bw wants to merge 42 commits into
mainfrom
vault/pm-32384/update-copy-new-to-create-add-browser

Conversation

@jengstrom-bw

@jengstrom-bw jengstrom-bw commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎟️ Tracking

Jira

📔 Objective

Update copy from New ... to Add ... or Create ...

📸 Screenshots

Screen.Recording.2026-06-23.at.2.14.47.PM.mov

@jengstrom-bw
add feature flag with temporary name
19b0d18
@jengstrom-bw
update copy for collection dialog based on feature flag
8cd4837
@jengstrom-bw
update copy and startIcon for domain rules based on feature flag
0dec2a5
@jengstrom-bw
update copy, icon and button type for new send dropdown based on feat…
794609e 
…ure flag
@jengstrom-bw
update copy for vault component based on feature flag
cfd975b
@jengstrom-bw
update copy for SM project dialog based on feature flag
6eb6394
@jengstrom-bw
update copy for SM secret-dialog based on feature flag
a63413e
@jengstrom-bw
update copy and startIcon for SM service accounts list based on featu…
63dd623 
…re flag
@jengstrom-bw
update copy for SM new-menu based on feature flag
dfe2572
@jengstrom-bw
update copy and startIcon for SM projects list based on feature flag
61d6596
@jengstrom-bw
update copy and startIcon for SM secrets list based on feature flag
083bd42
@jengstrom-bw
update copy for new send dropdown V1 and V2 based on feature flag
a4fd1fd
@jengstrom-bw
update copy for add edit dialog based on feature flag
ba6cb32
@jengstrom-bw
update copy for new cipher menu based on feature flag
db6725d
@jengstrom-bw
update copy for vault item dialog based on feature flag
f856029
@jengstrom-bw
update copy for AC groups and group add edit based on feature flag
172b022
@jengstrom-bw
update copy and icon for domain verification based on feature flag
e2cbcbb
@jengstrom-bw
fix tests
e0d4dc5
@jengstrom-bw
update feature flag name
3a264d0
@jengstrom-bw
add i18n keys used by lib components in browser and desktop
be5f61c
@jengstrom-bw
update feature flag variable name
3b932d2
@jengstrom-bw
Merge branch 'main' into vault/pm-32402/update-copy-from-new-to-creat…
29a5b06 
…e-web-app
@jengstrom-bw
update individual vault empty button to be secondary and no plus icon
b78057f
@jengstrom-bw
update AC empty vault add button v1/v2
d3770e1
@jengstrom-bw
update SM add machine account modal copy
5eea120
@jengstrom-bw
update new domain modal copy
bd8d4d5
@jengstrom-bw
fix tests
209608b
@jengstrom-bw
Merge branch 'main' into vault/pm-32402/update-copy-from-new-to-creat…
1421259 
…e-web-app
@jengstrom-bw
Merge branch 'main' into vault/pm-32402/update-copy-from-new-to-creat…
6cf6a34 
…e-web-app
@jengstrom-bw
Merge branch 'main' into vault/pm-32402/update-copy-from-new-to-creat…
72450bd 
…e-web-app
@jengstrom-bw jengstrom-bw added the t:feature Change Type - Feature Development label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.37%. Comparing base (75a0068) to head (414f616).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...up/components/vault/add-edit/add-edit.component.ts 40.00% 0 Missing and 12 partials ⚠️
...ault/popup/components/vault/view/view.component.ts 55.55% 0 Missing and 4 partials ⚠️
...c/new-send-dropdown/new-send-dropdown.component.ts 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21524      +/-   ##
==========================================
- Coverage   49.37%   49.37%   -0.01%     
==========================================
  Files        4105     4105              
  Lines      129304   129335      +31     
  Branches    19797    19813      +16     
==========================================
+ Hits        63844    63858      +14     
- Misses      60732    60733       +1     
- Partials     4728     4744      +16

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Jun 29, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jengstrom-bw jengstrom-bw marked this pull request as ready for review June 29, 2026 22:32
@jengstrom-bw jengstrom-bw requested review from a team as code owners June 29, 2026 22:32
@jengstrom-bw jengstrom-bw requested a review from nikwithak June 29, 2026 22:32
@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the browser vault and Send dropdown copy changes that swap "New" for "Add"/"Create" behind the PM32380_BtnTextAddCreate feature flag. Verified the feature flag is defined (defaults to FALSE), all referenced i18n keys exist in the affected locales (browser for vault headers; browser/desktop/web for the shared Send create/createSendV2 keys), and the toSignal + flag pattern matches the established convention used across ~25 other components. Test updates correctly mock getFeatureFlag$ to return of(false).

Code Review Details

No findings. The change is well-scoped, feature-flagged, and consistent with existing patterns. SshKey and the unchanged edit cases correctly omit SentenceCase key variants where no such key exists.

harr1424
harr1424 approved these changes Jun 29, 2026
View reviewed changes

@harr1424 harr1424 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools owned changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harr1424 harr1424 harr1424 approved these changes
@nikwithak nikwithak Awaiting requested review from nikwithak nikwithak is a code owner automatically assigned from bitwarden/team-vault-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

t:feature Change Type - Feature Development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jengstrom-bw @harr1424